airflow icon indicating copy to clipboard operation
airflow copied to clipboard

add recursive lookup for list of dirs

Open hg1112 opened this issue 1 year ago • 4 comments
trafficstars

We have been intending to use the AzureFileShareToGCSOperator to transfer files from azure file share to gcs. Problem being we to transfer whole bucket and this operator does not support recursive transfer.

So we added a boolean option for recursive traversal to AzureFileShareHook so that we can get the list of files through recursive tree if enabled. This will help transfer the files without deviating much with the original flow. By default it is set to False, imitating the existing the behavior


^ Add meaningful description above Read the Pull Request Guidelines for more information. In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed. In case of a new dependency, check compliance with the ASF 3rd Party License Policy. In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

hg1112 avatar May 04 '24 21:05 hg1112

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack

boring-cyborg[bot] avatar May 04 '24 21:05 boring-cyborg[bot]

Static code checks and Test(s) should be fixed

Taragolis avatar May 05 '24 10:05 Taragolis

Understood, I will add tests and fix the build. thank you @dirrao @Taragolis

hg1112 avatar May 05 '24 16:05 hg1112

@hg1112 not opposing your fix at all, but did you consider using ObjectStoragePath instead of this operator?

bolkedebruin avatar May 06 '24 08:05 bolkedebruin

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jun 21 '24 00:06 github-actions[bot]

Thank you for all the suggestions. Been a bit . I will try to incorporate ur suggestions

hg1112 avatar Jun 22 '24 17:06 hg1112

closing this PR , because used merge strategy instead of rebase to update latest code from main

hg1112 avatar Jun 23 '24 01:06 hg1112