airflow icon indicating copy to clipboard operation
airflow copied to clipboard

Published 20 hours ago • verified publisher icon apache

Add unit tests for EksCreateClusterTrigger

Open mateuslatrova opened this issue 9 months ago • 2 comments

Related: https://github.com/apache/airflow/issues/35442

This PR adds unit tests for the EksCreateClusterTrigger trigger from the Airflow AWS provider package.

mateuslatrova avatar May 01 '24 15:05 mateuslatrova

You need to remove this line:

https://github.com/apache/airflow/blob/c434c6b98911d71f27910d7d30cf966462157612/tests/always/test_project_structure.py#L75

Taragolis avatar May 01 '24 16:05 Taragolis

@mateuslatrova can you handle the above comment?

eladkal avatar May 06 '24 08:05 eladkal

@mateuslatrova can you handle the above comment?

Sorry I'm late! Just pushed the asked change.

mateuslatrova avatar May 08 '24 22:05 mateuslatrova

I made a mistake because I thought this branch was already merged, so I had to reopen the PR. Here it is: https://github.com/apache/airflow/pull/39508

Now, it also has unit tests for the EksDeleteClusterTrigger class.

mateuslatrova avatar May 09 '24 01:05 mateuslatrova