airflow icon indicating copy to clipboard operation
airflow copied to clipboard

Fix static file caching is disabled in Airflow Webserver.

Open VertexToEdge opened this issue 9 months ago • 2 comments

close #39344

Above Airflow 2.3.0, webserver's static file caching is disabled because of major updated Flask's breaking change. In Flask 2.0.x, default value of SEND_FILE_MAX_AGE_DEFAULT is changed from 12 hours to None on that version. SEND_FILE_MAX_AGE_DEFAULT affects Expires Field in HTTP response header. if it is None, Expires Field in HTTP response header is removed.

this pr add SEND_FILE_MAX_AGE_DEFAULT config for Flask explicitly in /airflow/www/app.py. It enables static file caching in Airflow webserver.

I checked Airflow configuration references and searched SEND_FILE_MAX_AGE_DEFAULT in Airflow codebase, but there's no way to enable static file caching for airflow webserver's Flask.

Airflow 2.9.0: As-Is

image

Airflow 2.9.0: To-Be (Caching Worked)

290_with_caching

Local test in /tests/www

image


^ Add meaningful description above Read the Pull Request Guidelines for more information. In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed. In case of a new dependency, check compliance with the ASF 3rd Party License Policy. In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

VertexToEdge avatar May 01 '24 12:05 VertexToEdge

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack

boring-cyborg[bot] avatar May 01 '24 12:05 boring-cyborg[bot]

Nice catch! We could probably cache it for a few weeks. Assets will only change between airflow version updates.

bbovenzi avatar May 01 '24 15:05 bbovenzi

Really cool catch. I can immediately see it locally and the UI feels immediately faster with this PR! THANKS!

(I think we could debate about the time, 12h sounds reasonable for me, still it will allow also proxy chains to cache files (if not HTTPS) - if somebody wants to have this nicer, still could be configurable. But 12h is a big improvement anyway!

jscheffl avatar May 04 '24 19:05 jscheffl

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

boring-cyborg[bot] avatar May 04 '24 19:05 boring-cyborg[bot]