airflow icon indicating copy to clipboard operation
airflow copied to clipboard

Handling exception getting logs when pods finish success

Open antoniocorralsierra opened this issue 1 year ago • 3 comments

Closes: https://github.com/apache/airflow/issues/39239


^ Add meaningful description above Read the Pull Request Guidelines for more information. In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed. In case of a new dependency, check compliance with the ASF 3rd Party License Policy. In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

antoniocorralsierra avatar Apr 28 '24 12:04 antoniocorralsierra

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack

boring-cyborg[bot] avatar Apr 28 '24 12:04 boring-cyborg[bot]

Also static checks need fixing. The best way would be to set up pre commit locally as we mention in our contributors guidelines

amoghrajesh avatar Apr 29 '24 13:04 amoghrajesh

can you rebase and resolve conflicts?

eladkal avatar May 01 '24 10:05 eladkal

Something new?

antoniocorralsierra avatar May 27 '24 09:05 antoniocorralsierra

Something new?

Let us know when you rebase @antoniocorralsierra - since you are first time contributor someone needs to approve the workflows (this is a security setting). So rebase and resolve conflict again and ping that you've done that so we can approve the workflow.

potiuk avatar May 27 '24 09:05 potiuk

Ready @potiuk , I had to do several rebase because the main branch was updating constantly.

antoniocorralsierra avatar May 27 '24 15:05 antoniocorralsierra

@potiuk Approve the workflow when you can

antoniocorralsierra avatar May 27 '24 15:05 antoniocorralsierra

Hi @potiuk reading the errors, I see that it is not belong to my changes. Rebase new changes and try again?

antoniocorralsierra avatar May 27 '24 21:05 antoniocorralsierra

Ready @potiuk , after many retries all checks had been passed

antoniocorralsierra avatar May 28 '24 08:05 antoniocorralsierra

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

boring-cyborg[bot] avatar May 28 '24 09:05 boring-cyborg[bot]