airflow icon indicating copy to clipboard operation
airflow copied to clipboard

Replace pod_manager.read_pod_logs with client.read_namespaced_pod_log in KubernetesPodOperator._write_logs

Open Lee-W opened this issue 1 year ago • 1 comments

Bring back the changes in https://github.com/apache/airflow/pull/36228 and improve the type annotation.

As mentioned in https://github.com/apache/airflow/pull/36228, we don't really need to call pod_manager.read_pod_logs and could call client.read_namespaced_pod_log directly instead


^ Add meaningful description above Read the Pull Request Guidelines for more information. In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed. In case of a new dependency, check compliance with the ASF 3rd Party License Policy. In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Lee-W avatar Apr 18 '24 11:04 Lee-W

I'll hold this for some time. I will prepare it for review when I finish all the implementations.

Lee-W avatar Apr 22 '24 11:04 Lee-W