airflow icon indicating copy to clipboard operation
airflow copied to clipboard

Enable none default ftp port

Open kerlion opened this issue 1 year ago • 6 comments


When I use ftp hook in my airflow env, it will wait till timeout when I use a none-standard ftp port. I fixed it by modify the source code. It has run for 2+ months without issue.

^ Add meaningful description above Read the Pull Request Guidelines for more information. In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed. In case of a new dependency, check compliance with the ASF 3rd Party License Policy. In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

kerlion avatar Apr 16 '24 01:04 kerlion

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack

boring-cyborg[bot] avatar Apr 16 '24 01:04 boring-cyborg[bot]

Is this the failed check? Issue: [B321:blacklist] FTP-related functions are being called. FTP is considered insecure. Use SSH/SFTP/SCP or some other encrypted protocol.

But it is ftp without TLS or ssl, we do have this scenario.

kerlion avatar Apr 16 '24 06:04 kerlion

This probably should have a test?

uranusjr avatar Apr 19 '24 03:04 uranusjr

Hi, is this ready for merging, anything else need I to do?

kerlion avatar Apr 22 '24 01:04 kerlion

Hi, is this ready for merging, anything else need I to do?

Have you seen this @kerlion ?

This probably should have a test?

potiuk avatar Apr 22 '24 09:04 potiuk

Can you please add unit test to cover this change?

Sorry, I do know know how to add unit test, but I tested it in my PROD env.

kerlion avatar Apr 28 '24 05:04 kerlion

Suppressed by https://github.com/apache/airflow/pull/39465

eladkal avatar May 27 '24 11:05 eladkal