gitSync: add envFrom to support proxy settings from k8s secret

[rasulkarimov]

This PR introduces support for proxy settings in the gitSync containers to accommodate scenarios where the git repository is located behind a corporate proxy server. The proxy settings can be configured in a Kubernetes secret with keys HTTPS_PROXY, HTTP_PROXY, and NO_PROXY. These settings are then accessed via the 'dags.gitSync.proxySettingsSecret' variable, which provides them as environment variables for the gitSync containers.

---

^ Add meaningful description above Read the Pull Request Guidelines for more information. In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed. In case of a new dependency, check compliance with the ASF 3rd Party License Policy. In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

[boring-cyborg[bot]]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points:

• Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
• Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
• Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack

[rasulkarimov]

@jedcunningham "restricting it artificially" - I agree with your point, I just wanted to follow the established pattern in the "git_sync_container" template. However, using gitSync.env is not ideal because proxy settings may contain secret credentials, which would require defining them directly in yaml.

Therefore, I have updated the PR to allow envFrom in git_sync_container. This will enable us to provide proxy settings with credentials to the git-sync container from a Kubernetes secret(without restricting it artificially).

[romsharon98]

look good, can you fix current tests to validate your changes?

[rasulkarimov]

look good, can you fix current tests to validate your changes?

Thank you! Fixed tests.

[rasulkarimov]

I'd much rather we move gitSync.env to accept V1EnvVars vs restricting it artificially like we are now.

@rasulkarimov, can you give that approach a shot instead?

Can we merge this PR?

[rasulkarimov]

I'd much rather we move gitSync.env to accept V1EnvVars vs restricting it artificially like we are now.

@rasulkarimov, can you give that approach a shot instead?

can we merge?

[eladkal]

cc @jedcunningham as you marked request changes

[boring-cyborg[bot]]

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

[jedcunningham]

Thanks @rasulkarimov! Sorry for the slow merge. Congrats on your first commit 🎉