airflow icon indicating copy to clipboard operation
airflow copied to clipboard

Add support for role arn for aws creds in storage transfer job operators

Open wlinamchurch opened this issue 1 year ago • 3 comments

closes: https://github.com/apache/airflow/issues/35271 related: Attempt to fix tests and checks from https://github.com/apache/airflow/pull/35292

This PR adds support to use role arn's for AWS credentials in storage transfer jobs. All of the substantive code changes were made in https://github.com/apache/airflow/pull/35292.

My additional contributions were to get the tests to pass and pre-commit checks to pass.


^ Add meaningful description above Read the Pull Request Guidelines for more information. In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed. In case of a new dependency, check compliance with the ASF 3rd Party License Policy. In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

wlinamchurch avatar Apr 10 '24 19:04 wlinamchurch

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack

boring-cyborg[bot] avatar Apr 10 '24 19:04 boring-cyborg[bot]

@Taragolis apologies if this is not the correct way to do this but tagging you since you looked at https://github.com/apache/airflow/pull/35292 previously.

wlinamchurch avatar Apr 15 '24 15:04 wlinamchurch

@Taragolis - pinging again following the directions of "be persistent". Again, apologies if this is not the correct procedure.

wlinamchurch avatar Apr 22 '24 11:04 wlinamchurch

Thanks @ferruzzi!

wlinamchurch avatar Apr 30 '24 22:04 wlinamchurch

@wlinamchurch You still need one more approval, perhaps drop a message in the slack #contributors channel asking for another set of eyes.

ferruzzi avatar Apr 30 '24 22:04 ferruzzi

Thanks @Taragolis!

wlinamchurch avatar Apr 30 '24 22:04 wlinamchurch

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

boring-cyborg[bot] avatar May 01 '24 02:05 boring-cyborg[bot]

Congrats! Thanks for your contribution and your patience!

ferruzzi avatar May 01 '24 02:05 ferruzzi