airflow icon indicating copy to clipboard operation
airflow copied to clipboard

Deprecation of AutoML services: Add deprecation warnings and raise exceptions for already deprecated ones

Open molcay opened this issue 10 months ago • 7 comments

Before merging this PR we need to merge #38633

This PR is for raising exception for the deprecated services of AutoML (Tables, Vision, Video Intelligence, Natural Language) which are EoL or will be EoL soon.


^ Add meaningful description above Read the Pull Request Guidelines for more information. In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed. In case of a new dependency, check compliance with the ASF 3rd Party License Policy. In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

molcay avatar Apr 02 '24 10:04 molcay

I think you need to rebase the PR. It's 52 commits behind and this is likely why it fails

potiuk avatar Apr 05 '24 15:04 potiuk

@molcay -> can you please rebase/resolve conflict and respond/mark as resolved all conversations that you think were resolved?

potiuk avatar Apr 23 '24 09:04 potiuk

cc: @VladaZakharova - there were some doubts for Google team about those deprecations - does this one look ok for you?

potiuk avatar Apr 24 '24 18:04 potiuk

cc: @VladaZakharova - there were some doubts for Google team about those deprecations - does this one look ok for you?

Hi! Thanks, yes, changes look good, LGTM

VladaZakharova avatar Apr 25 '24 09:04 VladaZakharova

@molcay -> can you please review and address/mark as resolved if they are - the comments made by @shahar1 ?

potiuk avatar Apr 25 '24 11:04 potiuk

@potiuk, Ohh I see, there are some hidden conversations. I totally missed them. Sorry for the inconvenience. I will try to address and resolve them as soon as possible.

molcay avatar Apr 26 '24 08:04 molcay

I will work on this test failure and send an update. Thank you for the review @shahar1 Also, thank you for pinging and guiding along the way @potiuk

molcay avatar May 02 '24 08:05 molcay

Hey @shahar1 ! Would be nice if you can check the changes here again

VladaZakharova avatar May 09 '24 09:05 VladaZakharova