airflow icon indicating copy to clipboard operation
airflow copied to clipboard

Fix triggerer race condition in HA setting

Open Lioscro opened this issue 10 months ago • 3 comments

Fix triggerer race condition when there are multiple instances

closes: #38599

Detailed description is in the issue linked above. I was able to reproduce the issue in the latest main branch.

^ Add meaningful description above Read the Pull Request Guidelines for more information. In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed. In case of a new dependency, check compliance with the ASF 3rd Party License Policy. In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Lioscro avatar Apr 02 '24 01:04 Lioscro

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack

boring-cyborg[bot] avatar Apr 02 '24 01:04 boring-cyborg[bot]

Could have sworn I ran pre-commit already...

Lioscro avatar Apr 04 '24 00:04 Lioscro

@uranusjr Thanks for the approval! I've taken all of your remaining suggestions. What is the process to getting this merged in?

Lioscro avatar May 06 '24 02:05 Lioscro

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

boring-cyborg[bot] avatar Jun 03 '24 08:06 boring-cyborg[bot]