airflow icon indicating copy to clipboard operation
airflow copied to clipboard

Add method to get metadata from GCS blob in GCSHook

Open jalengg opened this issue 1 year ago • 2 comments

  • Background: GCS blobs can be associated with metadata to make tracking and validating data easier. The GCSHook doesn't yet allow for the metadata attribute to be exposed, although it supports uploading of blobs and associating metadata with them.
  • Add get_metadata method to GCSHook
  • The get_metadata function would retrieve metadata from blobs which already reside in a GCS bucket.

^ Add meaningful description above Read the Pull Request Guidelines for more information. In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed. In case of a new dependency, check compliance with the ASF 3rd Party License Policy. In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

jalengg avatar Mar 22 '24 05:03 jalengg

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack

boring-cyborg[bot] avatar Mar 22 '24 05:03 boring-cyborg[bot]

LGTM

Just a small thing: it can be good to squash the commits

molcay avatar Apr 26 '24 09:04 molcay

LGTM I just rebased the branch. Lets confirm CI is green

Looks good.

potiuk avatar May 27 '24 09:05 potiuk

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

boring-cyborg[bot] avatar May 27 '24 09:05 boring-cyborg[bot]