airflow icon indicating copy to clipboard operation
airflow copied to clipboard
verified publisher icon apache

Fix visible DagRun doesn't point to the same dag run id

Open lotrias17 opened this issue 1 year ago • 4 comments

As stated by @nivdror, displaying a DAG RUN date different from the dag run id may cause confusion to users. I fixed this by changing the default displayed date to the Interval Start Date instead of Interval End Date.

closes: #35946

lotrias17 avatar Mar 21 '24 12:03 lotrias17

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack

boring-cyborg[bot] avatar Mar 21 '24 12:03 boring-cyborg[bot]

Gentle bump @bbovenzi. I do wonder if both places should use logical_date instead though.

jedcunningham avatar Apr 26 '24 17:04 jedcunningham

Let's go for logical date then

bbovenzi avatar Apr 26 '24 18:04 bbovenzi

Is there anything I should add or change?

lotrias17 avatar May 02 '24 13:05 lotrias17

Is there anything I could contribute to help merge this Pull Request?

lotrias17 avatar May 14 '24 15:05 lotrias17

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

boring-cyborg[bot] avatar May 16 '24 20:05 boring-cyborg[bot]