airflow icon indicating copy to clipboard operation
airflow copied to clipboard

fix(main): fix ImportError on examples dags

Open xionams opened this issue 1 year ago • 1 comments

this pull request is related to: https://github.com/apache/airflow-site/issues/945

the solution of "skipped" on the dag-loading when the virtualenv is not installed is wrap the dag loading with try-except and return None either using this logic will guarantee the ImportError exception will not stored in the DB and not thrown on the homepage as an error. so if virtualenv is not installed the examples are not loaded and the exception will not thrown

tested on Ubuntu WSL2


xionams avatar Feb 20 '24 20:02 xionams

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack

boring-cyborg[bot] avatar Feb 20 '24 20:02 boring-cyborg[bot]

Just one static check to fix

potiuk avatar Feb 22 '24 20:02 potiuk

i submitted fixes for the static checks. It should pass now

eladkal avatar Feb 23 '24 18:02 eladkal

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

boring-cyborg[bot] avatar Feb 23 '24 19:02 boring-cyborg[bot]