airflow icon indicating copy to clipboard operation
airflow copied to clipboard

Pass project_id to get_job in CloudRunExecuteJobOperator

Open LeonardMeyer opened this issue 1 year ago • 3 comments


The project id is passed pretty much everywhere except here. From my understanding it causes the hook to fallback to the account's project id only for get_job method. It seemed like an oversight to me.

^ Add meaningful description above Read the Pull Request Guidelines for more information. In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed. In case of a new dependency, check compliance with the ASF 3rd Party License Policy. In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

LeonardMeyer avatar Feb 20 '24 17:02 LeonardMeyer

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack

boring-cyborg[bot] avatar Feb 20 '24 17:02 boring-cyborg[bot]

I guess you need to add / update some unit tests.

potiuk avatar Feb 20 '24 21:02 potiuk

@dirrao Done

LeonardMeyer avatar Feb 21 '24 14:02 LeonardMeyer

#37201 I rebased and well apparently my work was a duplicate...

LeonardMeyer avatar Feb 22 '24 14:02 LeonardMeyer