airflow
airflow copied to clipboard
apache
templated fields logic checks for cloud_storage_transfer_service
The PR fixes assignment of parameters in constructor initialization for the google cloud_storage_transfer_service ensuring templated fields' parameters correspond to constructor initialization.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.
can u explain the purpose of this PR? In this issue https://github.com/apache/airflow/issues/36484 cloud_storage_transfer_service.py is shown as not implemented but when running pre-commit on it it looks like it already taken care. also in the pre-commit-config the file is not excluded (meaning template field works) maybe someone has fixed it but not related it to the story.
The list of files that needs to be fixed is in:
https://github.com/apache/airflow/blob/e5688b9ae9556f3e6da3b55437bea803fd0bb444/.pre-commit-config.yaml#L328-L335
Thus like what @romsharon98 mentioned. i am not sure how this PR relates to https://github.com/apache/airflow/issues/36484 ? Can you explain?
The service had minor deprecating changes I opted to take care of that were relating to #36484
Just wondering, anyone noticed this lines above of the changes 🙄 😵💫
https://github.com/apache/airflow/blob/2bcfe543c7781cd06430ff055864b811768b46ba/airflow/providers/google/cloud/operators/cloud_storage_transfer_service.py#L549-L556
Hey @Taragolis, I presumed the already implemented filter check ensures parameter backward compatibility and your suggestion accounts for property declaration
Hi @Taragolis should I add your code, replace or leave the changes as they are?