airflow icon indicating copy to clipboard operation
airflow copied to clipboard

Marking task state as Failed or Success without taskinstance edit role is resulting into partial empty screen

Open sreenusuuda opened this issue 1 year ago • 2 comments

Apache Airflow version

2.8.1

If "Other Airflow 2 version" selected, which one?

No response

What happened?

Marking task state as Failed or Success without task instance edit role is resulting into partial empty screen as shown below instead of Access Denied message.

What you think should happen instead?

We should show proper messaging saying user is lacking permission.

How to reproduce

  1. Create new user and assign user with can edit dags, can read dag runs, can edit dag runs permissions.
  2. Try to login with user and click on the specific Dag.
  3. Select task and try to mark it as Failed or Success.

Operating System

mac os

Versions of Apache Airflow Providers

No response

Deployment

Docker-Compose

Deployment details

No response

Anything else?

No response

Are you willing to submit PR?

  • [ ] Yes I am willing to submit a PR!

Code of Conduct

sreenusuuda avatar Feb 15 '24 15:02 sreenusuuda

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

boring-cyborg[bot] avatar Feb 15 '24 15:02 boring-cyborg[bot]

I did a regression and can confirm this small UI glitch. If user permissions are missing to edit task instances (needed to set state to success/failure) then the action buttons should rather be hidden to prevent the follow-up missing error handling in UI.

jscheffl avatar Feb 20 '24 22:02 jscheffl

Hey, can I work on this issue?

RodrigoGanancia avatar Mar 07 '24 00:03 RodrigoGanancia