airflow
airflow copied to clipboard
enhance druid connection parameters
closes: #35012
Enhancement on this PR:
- Support all the other connection parameters that exists on the
pydruid.connectin theget_connmethod. - Connections documentation
- Fix return values
Note:
The issue mentions about get_pandas_df method also. Since this is a DBAPIHook and the connection uses PEP8 DB API, there should be no problem to not override it from the DBAPIHook.
In addition, back in 2019 I wrote a test function for this specific method:
https://github.com/apache/airflow/blob/3d7c8f7d058284a4eb7e5e42eda56b3c284b7866/tests/providers/apache/druid/hooks/test_druid.py#L292-L305
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.
@blcksrx are you planning completing this PR?
Yeah, I do! Actually i asked a question but didn’t got any answers On Sun, Jan 7, 2024 at 07:47, Elad Kalif @.***> wrote:
@blcksrx are you planning completing this PR?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>
Actually i asked a question but didn’t got any answers
Which question?
About warning or decision about deprecation on the Major release On Sun, Jan 7, 2024 at 12:39, Elad Kalif @.***> wrote:
Actually i asked a question but didn’t got any answers
Which question?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>
About warning or decision about deprecation on the Major release
I answered about it in https://github.com/apache/airflow/pull/35244#discussion_r1404152273 Is there a followup question?
I see, Im gonna fix it this week. On Sun, Jan 7, 2024 at 12:47, Elad Kalif @.***> wrote:
About warning or decision about deprecation on the Major release
I answered about it in #35244 (comment) Is there a followup question?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.