airflow
airflow copied to clipboard
Add optional from_email parameter to EmailOperator
closes: https://github.com/apache/airflow/issues/33287
Add optional from_email parameter to EmailOperator which allows users to provide sender emails in Dags.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst
or {issue_number}.significant.rst
, in newsfragments.
Related to #33287
also related to #30531 cc: @hussein-awala
Have you considered adding test cases to verify the new behavior?
Have you considered adding test cases to verify the new behavior?
You are right. Let me update the test to check whether this field is passed to backend.
I have updated the test for verifying new from_email parameter.
@potiuk , would you be able to approve the test workflow for latest commit. Need to re-run the tests as I have email test.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
Will this get merged to main?
@hussein-awala , Can you please review this and check if this PR can be merged?
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
@hussein-awala , Did you get a chance to review this PR?
Look like the Airflow team isn't interested in this feature. Hence closing this PR.