airflow icon indicating copy to clipboard operation
airflow copied to clipboard

Add optional from_email parameter to EmailOperator

Open shakeelansari63 opened this issue 1 year ago • 11 comments

closes: https://github.com/apache/airflow/issues/33287

Add optional from_email parameter to EmailOperator which allows users to provide sender emails in Dags.


^ Add meaningful description above Read the Pull Request Guidelines for more information. In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed. In case of a new dependency, check compliance with the ASF 3rd Party License Policy. In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

shakeelansari63 avatar Aug 10 '23 14:08 shakeelansari63

Related to #33287

shakeelansari63 avatar Aug 10 '23 14:08 shakeelansari63

also related to #30531 cc: @hussein-awala

potiuk avatar Aug 10 '23 14:08 potiuk

Have you considered adding test cases to verify the new behavior?

vijayasarathib avatar Aug 10 '23 15:08 vijayasarathib

Have you considered adding test cases to verify the new behavior?

You are right. Let me update the test to check whether this field is passed to backend.

shakeelansari63 avatar Aug 10 '23 16:08 shakeelansari63

I have updated the test for verifying new from_email parameter.

shakeelansari63 avatar Aug 10 '23 16:08 shakeelansari63

@potiuk , would you be able to approve the test workflow for latest commit. Need to re-run the tests as I have email test.

shakeelansari63 avatar Aug 10 '23 18:08 shakeelansari63

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Sep 25 '23 00:09 github-actions[bot]

Will this get merged to main?

Franz1241 avatar Sep 25 '23 00:09 Franz1241

@hussein-awala , Can you please review this and check if this PR can be merged?

shakeelansari63 avatar Sep 25 '23 13:09 shakeelansari63

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Nov 10 '23 00:11 github-actions[bot]

@hussein-awala , Did you get a chance to review this PR?

shakeelansari63 avatar May 03 '24 07:05 shakeelansari63

Look like the Airflow team isn't interested in this feature. Hence closing this PR.

shakeelansari63 avatar Jun 16 '24 15:06 shakeelansari63