airflow icon indicating copy to clipboard operation
airflow copied to clipboard

Change dataprep system tests assets

Open MrGeorgeOwl opened this issue 2 years ago • 1 comments


^ Add meaningful description above

Read the Pull Request Guidelines for more information. In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed. In case of a new dependency, check compliance with the ASF 3rd Party License Policy. In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

MrGeorgeOwl avatar Sep 19 '22 12:09 MrGeorgeOwl

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst) Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack

boring-cyborg[bot] avatar Sep 19 '22 12:09 boring-cyborg[bot]

@MrGeorgeOwl Please rebase the PR (and resolve comments if they are resolved)

bhirsz avatar Sep 29 '22 12:09 bhirsz

Conflicts need to be solved after strings normalisation

potiuk avatar Oct 24 '22 22:10 potiuk

eh.. conflicts again

potiuk avatar Oct 31 '22 04:10 potiuk

@potiuk all conflicts were resolved 😄

lwyszomi avatar Nov 10 '22 09:11 lwyszomi