airflow icon indicating copy to clipboard operation
airflow copied to clipboard

Fix pod_template imagePullPolicy

Open mabrikan opened this issue 3 years ago • 2 comments

Fix imagePullPolicy in provided pod_template.yaml

Use .Values.images.pod_template.pullPolicy

mabrikan avatar Sep 15 '22 20:09 mabrikan

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst) Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack

boring-cyborg[bot] avatar Sep 15 '22 20:09 boring-cyborg[bot]

Yes, we should. @mabrikan, can you expand this test to cover the pull policy also? Thanks!

https://github.com/apache/airflow/blob/52560b87c991c9739791ca8419219b0d86debacd/tests/charts/test_pod_template_file.py#L281-L290

jedcunningham avatar Sep 19 '22 16:09 jedcunningham

Done :heavy_check_mark: FYA @jedcunningham @potiuk @dstandish

mabrikan avatar Sep 25 '22 21:09 mabrikan

Awesome work, congrats on your first merged pull request!

boring-cyborg[bot] avatar Sep 27 '22 15:09 boring-cyborg[bot]