airflow icon indicating copy to clipboard operation
airflow copied to clipboard

DatabricksSubmitRunOperator dbt task support

Open gaborratky-db opened this issue 3 years ago • 1 comments

This PR adds support for the upcoming dbt_task to DatabricksSubmitRunOperator.

Databricks is launching the Public Preview of the dbt task [1] soon, and this small change adds first-class support to DatabricksSubmitRunOperator. The official documentation for the dbt task will go live as part of the Public Preview.

Please let me know if the PR should include any other changes related to supporting the new task type.

Checklist

  • [ ] Add news fragment to PR
  • [ ] Tests and PR checks pass

[1] https://www.databricks.com/blog/2022/06/29/top-5-workflows-announcements-at-data-ai-summit.html

gaborratky-db avatar Aug 09 '22 16:08 gaborratky-db

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst) Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack

boring-cyborg[bot] avatar Aug 09 '22 16:08 boring-cyborg[bot]

Hello @mik-laj, how are you? Being a first-time contributor, can I ask you to approve running the workflows so that I can address any issues the PR checks raise? The change is a minor improvement to DatabricksSubmitRunOperator.

Also, cc-ing @potiuk, who has previously handled Databricks-related PRs. Thank you all!

gaborratky-db avatar Aug 11 '22 09:08 gaborratky-db

Ci starting.

mik-laj avatar Aug 11 '22 09:08 mik-laj

Hi @mik-laj, the CI checks seem to have failed on unrelated issues (docker: i/o timeout & breeze: command not found), would it be possible to run these checks again to arrive at a successful state? Thank you and have a great weekend!

gaborratky-db avatar Aug 12 '22 15:08 gaborratky-db

Can you do a rebase?

mik-laj avatar Aug 12 '22 16:08 mik-laj

@mik-laj rebased to latest main

gaborratky-db avatar Aug 15 '22 11:08 gaborratky-db

Thanks for the suggestion, @mik-laj; the PR has passed all checks. Is there anything else I can do ahead of your code review?

gaborratky-db avatar Aug 16 '22 07:08 gaborratky-db

Awesome work, congrats on your first merged pull request!

boring-cyborg[bot] avatar Aug 26 '22 20:08 boring-cyborg[bot]

Thank you for the review and merging of the changes, @potiuk!

gaborratky-db avatar Aug 29 '22 07:08 gaborratky-db