airflow
airflow copied to clipboard
HostAliases support for Scheduler, Worker, Trigger and Webserver
This PR adds scheduler.hostAliases
and webserver.hostAliases
parameter in helm chart in order to use kubernetes HostAliases in scheduler and webserver pods.
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst) Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
- In case of a new feature add useful documentation (in docstrings or in
docs/
directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it. - Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the Airflow Coding style. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack
Can we add this feature to Helm Chart 1.7.0?
Can we add this feature to Helm Chart 1.7.0?
First it would have to be reviewed and apprved as all other PRs. You need to exercise a bit of patience to get there.
Already edited what you comment and added hostAlises to the triggerer component too. This would make hostAliases available for Scheduler, Worker, Triggerer and Webserver.
Hi, I don´t know what to do this this PR rigth now.. Literally is my first PR
Hi, I don´t know what to do this this PR rigth now.. Literally is my first PR
If you deleted stuff accidentally, If you have no idea where things get wrong - close it, open a new one and start from scratch copying new code. This is nothing Airflow specific (though we use rebase workflow) - but you can read CONTRIBUTING.rst and possibly search the internet on rebasing, solving conflicts etc. If you have no experience, then start small and take your time to learn. No hurry - you can even take online courses. When you want to contribute to open-source you need ot be self-driven , self-learning and self sufficient and while some help and guidance is given, usually it is in the form of comments in PR for concrete changes or documentation (like CONTRIBUTING) written down for you to read and learn rathe than individual hand-holding and instructing step-by-step