airflow icon indicating copy to clipboard operation
airflow copied to clipboard

Container specific extra environment variables

Open rishkarajgi opened this issue 2 years ago • 5 comments


Adds the ability to inject additional environment variables to specific containers. This currently supports addition to scheduler, webserver, worker, triggerer, flower, cleanup jobs and wait-for-migrations containers

^ Add meaningful description above

Read the Pull Request Guidelines for more information. In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed. In case of a new dependency, check compliance with the ASF 3rd Party License Policy. In case of backwards incompatible changes please leave a note in a newsfragement file, named {pr_number}.significant.rst, in newsfragments.

rishkarajgi avatar Jul 01 '22 12:07 rishkarajgi

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst) Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack

boring-cyborg[bot] avatar Jul 01 '22 12:07 boring-cyborg[bot]

this PR will need chart tests

aliotta avatar Jul 01 '22 18:07 aliotta

Approach looks good. We should also do cleanup and the jobs.

jedcunningham avatar Jul 05 '22 17:07 jedcunningham

You should use env, not extraEnv. extraEnv is already used globally for thing based config, so having one a string and another a list is confusing:

https://github.com/apache/airflow/blob/2af19f16a4d94e749bbf6c7c4704e02aac35fc11/chart/values.yaml#L300-L307

@jedcunningham Have updated extraEnv to env as a property under each container

rishkarajgi avatar Jul 12 '22 08:07 rishkarajgi

Let's keep this PR to just env vars. Labels should be done in a separate PR.

Had to merge the two PRs to generate a helm chart for testing. Shall keep it in two separate PRs

rishkarajgi avatar Jul 13 '22 13:07 rishkarajgi

Awesome work, congrats on your first merged pull request!

boring-cyborg[bot] avatar Aug 18 '22 18:08 boring-cyborg[bot]