airflow icon indicating copy to clipboard operation
airflow copied to clipboard

added component specific labels

Open mayankbatra123 opened this issue 2 years ago • 4 comments


^ Add meaningful description above

Read the Pull Request Guidelines for more information. In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed. In case of a new dependency, check compliance with the ASF 3rd Party License Policy. In case of backwards incompatible changes please leave a note in a newsfragement file, named {pr_number}.significant.rst, in newsfragments.

mayankbatra123 avatar Jun 26 '22 17:06 mayankbatra123

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst) Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack

boring-cyborg[bot] avatar Jun 26 '22 17:06 boring-cyborg[bot]

@mayankbatra123 Is this PR feature complete? @jedcunningham can we expedite this for an upcoming astronomer feature?

rishkarajgi avatar Jul 01 '22 12:07 rishkarajgi

@mayankbatra123 - I think everything we work on here is community Airflow.

If you want to discuss with astronomer on adding stuff for Astronomer, this is not the right forum (and this one is wrong). I am not even sure what you are talking about here.

potiuk avatar Jul 01 '22 19:07 potiuk

This one has static chceks and docs failing. You need to fix it before we review it @mayankbatra123

potiuk avatar Jul 04 '22 21:07 potiuk

This one’s pretty broken

uranusjr avatar Aug 17 '22 01:08 uranusjr

Closing this as #25031 has added this feature. Thanks @mayankbatra123!

jedcunningham avatar Aug 23 '22 18:08 jedcunningham