apache
rename GKEStartPodOperator -> GKEPodOperator
KubernetesPodOperator EksPodOperator GKEStartPodOperator
we could fix this inconsistency by renaming GKEStartPodOperator -> GKEPodOperator or even GkePodOperator ?
We used to have discussions about operator naming and agreed that every operator should have a verb, so GKEStartPodOperator is a correct name for this operator, GKEPodOperator is not aligned with our rules.
Discussion thread: https://lists.apache.org/thread/6k9jzrd2jzsmz073m68b49zz2zhlzhfv
I think that the operator should describe the behavior(verb), hook should describe a service(noun). These are other parts of speech. In my opinion, HiveOperator should be named HiveExecuteQuery. Hook will be called Hive. Then there will be no name conflicts.
But I do like the verb/noun idea. That's a really nice way of thinking about what belongs where.
I completely agree that the operator names have been a bit muddled, HiveExecuteQuery sounds better to me.
Then GKEStartPodOperator is not doing what it say
cause the GKEStartPodOperator is not only starting a pod , but it's starting , tracking and waiting for end of the pod (and also re-attach)
So a better name could be KubernetesRunPodOperator ? GKERunPodOperator ...
KubernetesRunPodOperator sound good to me, but we should discuss it in a wider group, because it is one of the most popular operators. Can you create a thread on mailing list?
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Are we sure we want to get here? KPO is such a common name, and such ubiquitous all over the place that I am hesitating quite a bit to renaming it. KRPO sounds already pretty bad.
In this case I am not sure if consistency is a king any more
GKEStartPodOperator -> GKEPodOperator
@potiuk ?
Sounds much better :) - but I woudl love to hear what others say.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.