airflow icon indicating copy to clipboard operation
airflow copied to clipboard
verified publisher icon apache

Rename DagRun queue state to avoid confusion with TaskInstance

Open eladkal opened this issue 3 years ago • 8 comments

Body

Currently both DagRun and TaskInstance use queue as state (which is not related one to another at all) Screen Shot 2022-05-31 at 12 38 44 Screen Shot 2022-05-31 at 12 39 22

I find that this is very confusing! because Queue DagRun actually means that the DagRun didn’t even start while queue task means it passed the scheduler and waiting for worker slot.

My suggestion simply not to use the same string (queue) to describe the different meaning.

(*) We also use Running for both DagRuns/tasks but I find this specific one less confusing as it actually means quite the same (something in worker is being executed).

Slack thread: https://apache-airflow.slack.com/archives/CCPRP7943/p1653990216805099

Committer

  • [X] I acknowledge that I am a maintainer/committer of the Apache Airflow project.

eladkal avatar May 31 '22 12:05 eladkal

+1 providing that we handle API backwards compatibility well

potiuk avatar May 31 '22 12:05 potiuk

When the task is waiting for worker it is also "didn't even start" in terms of operator execution.

In my experience it is always tricky to get the logic of scheduled/queued TI for the new people, but there was no problems with the DagRun states naming.

ei-grad avatar Jun 09 '22 14:06 ei-grad

What would be the new proposed name for this state? "Pending"? This issue doesn't contain any mentions about the new name, and it is not clear would it hurt the UX much without it.

ei-grad avatar Jun 09 '22 15:06 ei-grad

Pending sounds reasonable to me.

uranusjr avatar Aug 17 '22 04:08 uranusjr

Is this issue only about renaming the state in UI? I have not worked on any UI-related issues before. Could I take a stab at this?

Bowrna avatar Oct 04 '22 04:10 Bowrna

The name “queued” actually comes from the backend, but I think we could make this a UI-only change to avoid needlessly spending time migrating the database. Or at least we can make the UI change now and modify the backend later.

uranusjr avatar Oct 04 '22 05:10 uranusjr

Yeah it shouldn't be hard to change any instance of dagrun queued to pending. We may want a new color too, no?

bbovenzi avatar Jun 25 '24 11:06 bbovenzi

Or at least we can make the UI change now and modify the backend later.

Now that Airflow 3 is on the table maybe we should reconsider do both together?

eladkal avatar Jun 25 '24 11:06 eladkal