airflow icon indicating copy to clipboard operation
airflow copied to clipboard

UI Doesn't use all of Bootstrap theme css, Airflow 2.0

Open hedrickw opened this issue 4 years ago • 4 comments

Apache Airflow version: 2.0.0

Environment: Ubuntu

  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:

What happened:

Picked Cyborg.css in web_server config but background is still default image

What you expected to happen:

How to reproduce it:

Anything else we need to know:

hedrickw avatar Dec 18 '20 18:12 hedrickw

@hedrickw TIL that APP_THEME was a thing, so it certainly wasn't considered in the 2.0 refresh. I'm curious, is there a specific reason why you want to use an alternative theme?

ryanahamilton avatar Mar 25 '21 18:03 ryanahamilton

Because we are stuck on an old version of Bootstrap (via secondary dependency through FAB), we had to move away from some of the previous Bootstrap theme patterns. I propose that instead of trying to accommodate this, that we instead remove the feature. It appears to only add maintenance overhead. If differentiation between Airflow deployments is the goal, there is the option to set a different nav bar color by setting a color value in the navbar_color config.

ryanahamilton avatar Apr 01 '21 13:04 ryanahamilton

@hedrickw I've opened #15277 to remove the support of APP_THEME going forward. Please offer up any feedback if you don't believe this is the best course of action.

ryanahamilton avatar Apr 08 '21 14:04 ryanahamilton

I think that's the correct course of action!

hedrickw avatar Apr 08 '21 14:04 hedrickw

Resolved in https://github.com/apache/airflow/pull/15277. Closing

pierrejeambrun avatar Nov 19 '22 12:11 pierrejeambrun

@pierrejeambrun it was reverted and raised new draft PR https://github.com/apache/airflow/pull/25656 can be merged only for Airflow 3.0

eladkal avatar Nov 19 '22 17:11 eladkal

@eladkal Thank you elad, I missed that part

pierrejeambrun avatar Nov 19 '22 17:11 pierrejeambrun