airflow-site
airflow-site copied to clipboard
apache
Add dark theme, by @prefers-color-theme
What do you see as an issue?
For many users - difficult to read from the white background. Especially at low light conditions.
Solving the problem
By leveraging this CSS media query https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme
Anything else
No response
Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
Code of Conduct
- [X] I agree to follow this project's Code of Conduct
Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.
![boring-cyborg[bot] avatar](https://avatars.githubusercontent.com/in/50386?v=4 "Published by a pub.dev verified publisher"){kind=small}
Closing as duplicate of https://github.com/apache/airflow/issues/11334 This is indeed something we are looking into and it's planned as part of AIP-38
But this is about documentation pages.
So it should be added to "airlfow-site" project - because this is where we keep our documentation website theme and everything. Please add it there.
GitHub allows to transfer issues between repos.. let me try to transfer it to the airflow site repo
Hey @vitaly-zdanevich, are you still working on it? Or else I am willing to take this issue as no dark mode is too much trouble for me 😢😭
@eladkal @porwalshreyaa i'll like to join in on this , see if we can get this done in a short time., this is a real blocker for me too.
Feel free @mayo7e -> dark mode is added already in upcoming Airflow 2.10 -> https://github.com/apache/airflow/pull/39355, already works in main, probably what is needed is to enable it automatically by @prefers-color-theme -> if it does not work like that already.
BTW. The PR for dark mode got the title of "PR of the month" in June unanimously, so you are not the only want that considered that as a blocker - see https://lists.apache.org/thread/fnlswr7w69oofxp6g8rkc5052yxc7rs2
@potiuk why did you unassign me? I am still working on it and he asked to join me, maybe you could just assign us both?
@potiuk Thanks! I've told my friends that I am working on this, if I don't get to merge, I'll be in trouble 😂
@porwalshreyaa happy to work with you on this! Is there a feature branch you already created that I can clone? If you have the tasks defined, I can get started with a task right away. If not, perhaps we can start by defining the tasks together.
@mayo7e I haven't created a branch yet, I just read the mdn doc. Maybe we can do divide pages you can do one page completely by yourself and I'll do another, or you have something else in mind? I am yet to define tasks
@porwalshreyaa Perhaps you can point me to the MDN documentation in question so I can get up to speed. I'm not sure what you mean by "divide pages." According to @potiuk , all that remains is adding the functionality for OS theme preference to be reflected in the Airflow UI while still keeping the toggle button option available.
@porwalshreyaa Alright, I'll take some time to go over the documentation and share my thoughts on how we can divide the tasks or perhaps you have thoughts on this already?.
@mayo7e I am reading the code rn. Let's discuss it after we are both done. Btw, right now it's 5.30 pm in India. Are you available 4-5 hours later or it'll be too late for you to discuss?
@potiuk I am reading the code rn. Let's discuss it after we are both done. Btw, right now it's 5.30 pm in India. Are you available 4-5 hours later or it'll be too late for you to discuss?
I have almost no knowledge there to discuss and we usually discuss things offline in PRs, I doubt there is a need for synchronous call and spending time of few people trying to set-it-up on call while it can be discussed offline