airflow-client-python icon indicating copy to clipboard operation
airflow-client-python copied to clipboard

Fix wrong use of $ref and nullable

Open 11010cy opened this issue 3 years ago • 1 comments

Composed schemas $ref and nullable are not supported. And inline composed schemas has bug using tooling.

Per the openapi spec, properties adjacent to refs are ignored: https://github.com/OAI/OpenAPI-Specification/blob/main/versions/3.1.0.md#reference-object This object cannot be extended with additional properties and any properties added SHALL be ignored. except for summary and description.

dag_run_timeout:
              nullable: true
              $ref: '#/components/schemas/TimeDelta'
dag_run_timeout:
 oneOf:
  - type: null
  - $ref: '#/components/schemas/TimeDelta'

All the above definitions are not correct.

related issues: OpenAPITools/openapi-generator/issues/11352 apache/airflow-client-python/issues/40

[airflow] related prs pr:apache/airflow/pull/21080

11010cy avatar Jan 25 '22 07:01 11010cy

@msumit can you check this pr?

alexInhert avatar May 17 '22 12:05 alexInhert

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Feb 12 '23 00:02 github-actions[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Apr 02 '23 00:04 github-actions[bot]