age icon indicating copy to clipboard operation
age copied to clipboard

Published 20 hours ago • verified publisher icon apache

Fix issue #945 unaliased match clause giving incorrect results in count

Open maazzzzz opened this issue 1 year ago • 3 comments

unaliased match clause would give incorrect results in count because the node wasn't being added to the join tree. Fixed it by adding unaliased match clauses with valid label names to join tree.

  • added entry for unaliased nodes with label names in macro
  • added regression test for proposed change

resolves #945

maazzzzz avatar Jun 13 '23 13:06 maazzzzz

@jrgemignani can you please review this one. I think this was missed.

MuhammadTahaNaveed avatar Jul 18 '23 17:07 MuhammadTahaNaveed

@maazzzzz Does it produce correct result for the below query?

MATCH () RETURN count(*)

MuhammadTahaNaveed avatar Jul 18 '23 21:07 MuhammadTahaNaveed

@MuhammadTahaNaveed checked and it doesn't, missed that case when testing. I'll try looking into it if I get the time but if anyone else could look into it, thatd be great.

maazzzzz avatar Jul 19 '23 05:07 maazzzzz

This PR is stale because it has been open 45 days with no activity. Remove "Abondoned" label or comment or this will be closed in 7 days.

github-actions[bot] avatar May 11 '24 00:05 github-actions[bot]

Issue addressed by this PR has already been resolved by PR #1288

MuhammadTahaNaveed avatar May 11 '24 11:05 MuhammadTahaNaveed