age icon indicating copy to clipboard operation
age copied to clipboard

Refactored imports and added docstrings to functions

Open hammadsaleemm opened this issue 1 year ago • 2 comments

I removed the line from .age import * since it is already imported in the next line. Instead of importing all modules using from .age import * and from .models import *, I explicitly imported the necessary functions/classes directly. I also added docstrings to all functions and modules to explain their purpose, inputs, and outputs, and added type annotations to all functions to improve code readability and maintainability.

I also renamed rawPrinter to RawPrinter to follow Python naming conventions and made it a separate class RawPrinter that inherits from ResultHandler to make it more extensible. Finally, I updated the connect function to return an Age object instead of None.

hammadsaleemm avatar Apr 26 '23 03:04 hammadsaleemm

@hammadsaleemm There is a python test case that is failing on this commit -- can you look into why it is failing?

dehowef avatar Apr 26 '23 19:04 dehowef

@hammadsaleemm There is a python test case that is failing on this commit -- can you look into why it is failing?

I'll look into it

hammadsaleemm avatar Apr 27 '23 02:04 hammadsaleemm

Never followed up. Closing

dehowef avatar Apr 19 '24 08:04 dehowef