Fix error with PG17 palloc0fast compilation

Open uhayat opened this issue 1 year ago • 3 comments

In PG17 palloc0fast is removed and palloc0 is instead

Sep 25 '24 00:09 uhayat

I think that change is correct. However, in this project, the condition by PG_VERSION_NUM may be unnecessary, as the branches are separated by PG version. (I don't know how to do this, as the PG17 branch has not yet been created.)

Sep 25 '24 12:09 shinyaaa

@uhayat I am okay with merging a change where palloc0fast is replaced by palloc0. But, we don't use version flags as stated by @shinyaaa above, so I won't approve that.

Sep 27 '24 14:09 jrgemignani

@jrgemignani understood. I updated the commit and removed the version check.

Sep 27 '24 16:09 uhayat

Anybody available for review ?

Oct 27 '24 09:10 uhayat

@uhayat See https://github.com/apache/age/issues/2111#issuecomment-2441084857

Oct 28 '24 15:10 jrgemignani