get_graph_oid function declaration return type uint32 definition Oid

[MironAtHome]

Describe the bug A clear and concise description of what the bug is. Code bug. Different declaration and definition of the function return parameter type

How are you accessing AGE (Command line, driver, etc.)? N/A

What data setup do we need to do? N/A

What is the necessary configuration info needed? N/A

What is the command that caused the error? N/A

Expected behavior N/A

Environment (please complete the following information): branches checked, master and PG16

Additional context Files, using GitHub UI for branch master as following https://github.com/apache/age/blob/master/src/include/catalog/ag_graph.h line #40 https://github.com/apache/age/blob/master/src/backend/catalog/ag_graph.c line #143

[jrgemignani]

@MironAtHome If you are going to change the function return type, you need to verify that all locations that call it will not have an issue with that change.

[MironAtHome]

I did. The good part is that it's only declaration that had uint32. Function definition + all function calls ( I could find ) had return value declared as Oid. I don't want to bias someone looking at the code as code reviewer, so read next few lines with a grain of salt. When I looked over function calls, that is get_graph_oid function, all of the calls return to variable named graph_oid, all, save for one, where it's named "graph" and its type is declared as Oid, as well. This is true for branches master, 12, 13, 14, 15 and 16, branch 11, for some reason, had type declared, as Oid in function declaration ( header file ). In case I missed one or another ( and I checked a few times ), please add comment, I am happy to fix.

[jrgemignani]

@MironAtHome Just wanted to make sure.

[github-actions[bot]]

This issue is stale because it has been open 60 days with no activity. Remove "Abondoned" label or comment or this will be closed in 14 days.