age icon indicating copy to clipboard operation
age copied to clipboard

Fix python driver's test

Open KTaskn opened this issue 8 months ago • 3 comments

Fixed a problem with python driver testing where arguments were not working properly.

KTaskn avatar Oct 14 '23 12:10 KTaskn

It works fine for me. Can you show me how it didn't work for you

dehowef avatar Nov 16 '23 23:11 dehowef

Maybe you can remove "dehowefeng" in the DSN string though and replace that with something generic

dehowef avatar Nov 16 '23 23:11 dehowef

@dehowef

It is not consistent with the readme, it should be able to be changed dynamically from the arguments as in the readme. Also, it is strange that your handle is in the code.

https://github.com/apache/age/blob/5fbe064a913f03dd13058cc21b7b7fb0cdf910cb/drivers/python/README.md?plain=1#L48C1-L57C4

KTaskn avatar Nov 22 '23 13:11 KTaskn

@dehowef, can you comment if this can be merged?

aked21 avatar Apr 10 '24 05:04 aked21

Closed for breaking the regression tests.

dehowef avatar Apr 17 '24 08:04 dehowef