age icon indicating copy to clipboard operation
age copied to clipboard

Haversine trigonometric function added

Open Allison-E opened this issue 1 year ago • 6 comments

More about the Haversine trigonometric function here.

Allison-E avatar Aug 12 '23 17:08 Allison-E

Looks good, but can you remove the changes you have made to the .gitignore file? Those are personal config changes we don't want them pushed to the main branch. Thank you @Allison-E

dehowef avatar Aug 15 '23 20:08 dehowef

Looks good, but can you remove the changes you have made to the .gitignore file? Those are personal config changes we don't want them pushed to the main branch. Thank you @Allison-E

Thank you. I've reverted the changes made.

Allison-E avatar Aug 19 '23 01:08 Allison-E

@Allison-E This PR needs to be rebased against the current master due to changes to the age--x.x.x.sql file.

jrgemignani avatar Dec 01 '23 23:12 jrgemignani

@Allison-E This PR needs to be rebased against the current master due to changes to the age--x.x.x.sql file.

@Allison-E Two points -

  1. The age--x.x.x.sql file was split up, your PR includes it again. You need to put your new function into the appropriate sql file for it. See the Makefile to see how age--x.x.x.sql was broken up. You likely need to bring your local repo up-to-date.
  2. I don't see the haversin function here, I see a date function?

jrgemignani avatar Dec 05 '23 15:12 jrgemignani

Thanks for pointing that out, @jrgemignani. I've reviewed the changes. I'll work on it and push the correct thing tomorrow.

Allison-E avatar Dec 11 '23 16:12 Allison-E

@Allison-E Any update?

jrgemignani avatar Apr 17 '24 23:04 jrgemignani

This PR is stale because it has been open 60 days with no activity. Remove "Abondoned" label or comment or this will be closed in 14 days.

github-actions[bot] avatar Jun 17 '24 00:06 github-actions[bot]

This PR was closed because it has been stalled for further 14 days with no activity

github-actions[bot] avatar Jul 01 '24 00:07 github-actions[bot]