age
age copied to clipboard
Haversine trigonometric function added
- Implemented the
haversin()
Cypher trigonometric function. - Wrote regression tests for the
haversin()
function.
More about the Haversine trigonometric function here.
Looks good, but can you remove the changes you have made to the .gitignore file? Those are personal config changes we don't want them pushed to the main branch. Thank you @Allison-E
Looks good, but can you remove the changes you have made to the .gitignore file? Those are personal config changes we don't want them pushed to the main branch. Thank you @Allison-E
Thank you. I've reverted the changes made.
@Allison-E This PR needs to be rebased against the current master due to changes to the age--x.x.x.sql file.
@Allison-E This PR needs to be rebased against the current master due to changes to the age--x.x.x.sql file.
@Allison-E Two points -
- The age--x.x.x.sql file was split up, your PR includes it again. You need to put your new function into the appropriate sql file for it. See the Makefile to see how age--x.x.x.sql was broken up. You likely need to bring your local repo up-to-date.
- I don't see the
haversin
function here, I see a date function?
Thanks for pointing that out, @jrgemignani. I've reviewed the changes. I'll work on it and push the correct thing tomorrow.
@Allison-E Any update?
This PR is stale because it has been open 60 days with no activity. Remove "Abondoned" label or comment or this will be closed in 14 days.
This PR was closed because it has been stalled for further 14 days with no activity