activemq icon indicating copy to clipboard operation
activemq copied to clipboard
verified publisher icon apache

AMQ-6148 Reusing LDAP context to avoid creating new connections

Open Dm-Chebotarskyi opened this issue 4 years ago • 2 comments

Description

Re-using LDAP context for authentication. The context is created only once and re-used each time ActiveMQ server established connection with ActiveMQ clients. Refactoring some code in LDAPLoginModule.java This PR is based on fix introduced to Artemis: https://github.com/apache/activemq-artemis/commit/f3a8619d7eeabded75f3725f2e77af267e8cb450#diff-706fd9b54d2aed5a0ea5d28fa7c70f7ee733672f7e91d847137517e3b147d716

Testing

Manual test authentication using LDAP

Issue

https://issues.apache.org/jira/browse/AMQ-6148

Dm-Chebotarskyi avatar Aug 19 '21 20:08 Dm-Chebotarskyi

Please rebase, and take a look at the comments about moving some clean-up tasks to finally {} blocks instead to prevent leaks or deadlock.

mattrpav avatar Aug 22 '22 23:08 mattrpav

Please rebase, and take a look at the comments about moving some clean-up tasks to finally {} blocks instead to prevent leaks or deadlock.

Hey Matt, thanks for the quick review. Could you please clarify what comments do you mean? I can't see any comments in the CR nor in the rebased code itself.

Dm-Chebotarskyi avatar Aug 23 '22 01:08 Dm-Chebotarskyi

@Dm-Chebotarskyi do you mind to squash the 9 commits in one and rebase ? If you prefer, I can do it myself and manually merge. Thoughts ?

jbonofre avatar Oct 14 '22 16:10 jbonofre

Thanks for the review @jbonofre . I will squash and update the PR shortly

Dm-Chebotarskyi avatar Oct 14 '22 16:10 Dm-Chebotarskyi

@Dm-Chebotarskyi awesome ! Thank you so much ! Let me know if I can help on anything.

jbonofre avatar Oct 14 '22 16:10 jbonofre