activemq icon indicating copy to clipboard operation
activemq copied to clipboard

[AMQ-7072] moving to JSON-B API instead of jackson

Open rmannibucau opened this issue 7 years ago • 3 comments

Goal is to let users switch the impl on need + using johnzon as default Issue was identified on TomEE where jackson is not desired in the distribution cause there is already johnzon and some

rmannibucau avatar Oct 13 '18 20:10 rmannibucau

R: @jbonofre

jbonofre avatar Oct 15 '18 13:10 jbonofre

Johnzon is fine using jsonb. I've started the review and rebase anyway.

jbonofre avatar Mar 22 '21 19:03 jbonofre

Overall the goal is to enable to use json-b and use the json-b contract (ie neither johnzon nor jackson must appear in compile scope in theory - until it is to be transitive but I'm speaking on a pure build perspective). I assume it should be tested with both impl - and maybe yasson - to ensure some portability - at least manually for the first round. After the question of the default in the distro can be discussed. The least changing is jackson but the most apache is johnzon and for AMQ it should be very close once fully migrated to json-b api so at the end I'd say 50-50 ;).

rmannibucau avatar Mar 22 '21 20:03 rmannibucau

I think we should do this in 5.19.x and go straight to Jakarta.

I don’t think it makes sense changing out a bunch of dependencies right before a major uplift to Jakarta.

The Jakarta works is ~80% done or so, so I don’t think it will be too long of a delay.

mattrpav avatar May 17 '23 21:05 mattrpav

+1 and maybe jsonp only to limit deps

rmannibucau avatar May 17 '23 21:05 rmannibucau

@mattrpav I'm fine with it. I'll wait till we have a jakarta ready version for 5.19.x and rebase so I can update the dependencies and the imports.

Or I can rebase on your branch https://github.com/apache/activemq/pull/996, but probably too early

jeanouii avatar May 22 '23 07:05 jeanouii

Agree for 5.19.x, I don't want to include this change in 5.18.x. I would keep this PR as it is, waiting 5.19.x update done.

jbonofre avatar May 22 '23 07:05 jbonofre

Closing as non active. Please reopen a new one if needed.

jbonofre avatar Oct 19 '23 14:10 jbonofre