activemq icon indicating copy to clipboard operation
activemq copied to clipboard

[AMQ-9683] java.io.IOException on idle HTTP/XA connection

Open colinwerner opened this issue 9 months ago • 5 comments

As described in https://issues.apache.org/jira/browse/AMQ-9683 an EMPTY payload was received in response to a GET, as an intermediate POST sent a shutdown.

This PR implements solution 1, where we ignore the exception IFF we are shutting down or we are shutdown.

Solution 2 is in https://github.com/apache/activemq/pull/1413. We only need one or the other...

colinwerner avatar Mar 17 '25 22:03 colinwerner

I think some tests can break with this change. I will double check.

jbonofre avatar May 25 '25 09:05 jbonofre

I think some tests can break with this change. I will double check.

Yes, I saw that but I would not reproduce them locally. Any ideas? We are currently forking and building our own binary, which is a bit of a pain to keep up with all the dependencies, so we really appreciate your insight here!

And thanks in advance!

colinwerner avatar May 26 '25 15:05 colinwerner

@jbonofre any luck here?

colinwerner avatar Jun 02 '25 20:06 colinwerner

@colinwerner on it 😄

jbonofre avatar Jun 03 '25 08:06 jbonofre

I'm checking one test that can be problematic (but not a blocker).

jbonofre avatar Jun 03 '25 14:06 jbonofre

IMO: This is the ideal scenario to add a counter metric. Logging can get clogged up/rotated/etc and having a counter makes it easy to monitor if this is happening in a on-off, or consistently.

mattrpav avatar Jun 09 '25 14:06 mattrpav

I think this first PR is fine as a quick fix. We can always improve later. The debug log message is good enough for now.

jbonofre avatar Jun 10 '25 15:06 jbonofre

Thank you @jbonofre -- much appreciated! I'll follow-up if we see any other issues!

colinwerner avatar Jun 10 '25 15:06 colinwerner