activemq icon indicating copy to clipboard operation
activemq copied to clipboard

WIP: [AMQ-9637] Add web socket connection limit.

Open Nikita-Shupletsov opened this issue 1 year ago • 2 comments

What problems does this PR solve? It adds maximumConnections support for WS transport.

Why is it beneficial to merge into ActiveMQ? all other transports have this limit. being able to limit the number of connections for WS transport brings in in par with the rest of transports.

How do you make sure this PR is well tested? I updated the existing amqp test to test amqp+ws and amqp+wss, added new tests for stomp+ws and mqtt+ws as well.

Nikita-Shupletsov avatar Dec 13 '24 19:12 Nikita-Shupletsov

On the surface, this looks like it might be a couple of commits-- ws socket handling clean-up and then the limit added.

TODO: Determine if this is done before or after the Jetty 12 update

mattrpav avatar Dec 13 '24 20:12 mattrpav

On the surface, this looks like it might be a couple of commits-- ws socket handling clean-up and then the limit added.

sounds good. I will split the PR into two

Nikita-Shupletsov avatar Dec 13 '24 22:12 Nikita-Shupletsov