activemq icon indicating copy to clipboard operation
activemq copied to clipboard

AMQ-9544 Deprecated WildcardFileFilter constructor

Open pa-deasy opened this issue 1 year ago • 2 comments

What problems does this PR solve? As per the WildcardFileFilter docs the WildcardFileFilter(String wildcard) constructor is deprecated. Replace this constructor with the recommended Builder.

Why is it beneficial to merge into ActiveMQ? Updates deprecated code with the recommended approach.

How do you make sure this PR is well tested? Ran all of the tests that were updated to ensure they are still passing. For abstract test classes, tested the classes which extend them.

pa-deasy avatar Aug 16 '24 22:08 pa-deasy

You probably need to re-run the tests. It seems to fail due to flakiness.

kenliao94 avatar Aug 17 '24 19:08 kenliao94

@mattrpav and @jbonofre, could you take a look at this PR when you have a chance? Thanks.

kenliao94 avatar Nov 08 '24 18:11 kenliao94