activemq icon indicating copy to clipboard operation
activemq copied to clipboard

[AMQ-9244] Add JWT authentication plugin

Open jbonofre opened this issue 1 year ago • 4 comments

jbonofre avatar Jun 21 '23 09:06 jbonofre

Generally speaking this looks more like a proof-of-concept (i.e. based on this blog post) rather than a feature which is ready to use. I'm not sure it makes sense to merge it at this point especially with no tests to validate the functionality and to mitigate future regressions.

jbertram avatar Jun 21 '23 19:06 jbertram

That's the starting point. The intention is not to merge right now. I wanted to share here as few users want to try. I will work on this PR after the releases plan.

jbonofre avatar Jun 22 '23 11:06 jbonofre

@jbonofre, understood. That wasn't clear from your comment on the Jira where you said,

It doesn't break anything, just add a new plugin, so I don't see problem to merge.

Thanks for the clarification.

jbertram avatar Jun 22 '23 13:06 jbertram

I went ahead and converted this to a draft PR. Generally speaking we should be using draft PRs if something is not ready to merge. This way it makes it clear it's still a work in progress. Marking things like this draft PRs in the future should hopefully help with the confusion about the state.

cshannon avatar Jun 22 '23 22:06 cshannon