activemq-nms-amqp icon indicating copy to clipboard operation
activemq-nms-amqp copied to clipboard

Published 20 hours ago • verified publisher icon apache

Amqnet 723

Open lukeabsent opened this issue 3 years ago • 7 comments

lukeabsent avatar Jul 26 '21 17:07 lukeabsent

Can these be separate prs please

michaelandrepearce avatar Jul 26 '21 17:07 michaelandrepearce

Can these be separate prs please

there is separate pr for 637, and separate for 723 723 was branched from 637, once 637 gets merged, I suppose there will be just 723 visible on the commit lists

lukeabsent avatar Jul 26 '21 17:07 lukeabsent

There is no jiras too in here. Can we seperate those too please.

michaelandrepearce avatar Jul 26 '21 17:07 michaelandrepearce

@lukeabsent whats left on this one, to take it out of draft?

michaelandrepearce avatar Sep 02 '21 09:09 michaelandrepearce

@michaelandrepearce I put PR to amqpnetlite that exposes method for estimating message size, it got merged. but its not released yet. well, we can discuss continuing without it and having own message body estimates.

lukeabsent avatar Sep 02 '21 20:09 lukeabsent

That's pretty odd feature to add in a library code. I don't see anything along these lines in qpid-jms. Why do we need this?

Havret avatar Sep 02 '21 20:09 Havret

@lukeabsent see comments, also conflicts.

michaelandrepearce avatar Sep 08 '21 08:09 michaelandrepearce

@lukeabsent whats occuring with this, its been 2 yrs and you didnt resolve @gemmellr comments, are we closing this?

michaelandrepearce avatar Sep 08 '23 03:09 michaelandrepearce

yes @michaelandrepearce from my side I think we can ignore/close this pr

lukeabsent avatar Sep 14 '23 21:09 lukeabsent