activemq-artemis
activemq-artemis copied to clipboard
apache
ARTEMIS-3983 Change docker base image version from JDK to JRE
I guess we would lose JDK diagnostic tools. What are the benefits to change base image from JDK to JRE?
Smaller uncompressed image size on disk.
I guess the decision depends on how these docker images are seen. Are they for development of Artemis itself, or to easy development of software using Artemis, or as a base images for production?
For Artemis development yes, JDK diag tools could be useful. For other purposes, I doubt so.
Ill let others discuss merits of jdk vs jre ... but this would require a jira, this isnt a small typo or doc fix.
@ViliusS, can you quantify the difference this will make in the size of the image?
For what it's worth, lots of folks use JDK tools during development and production (e.g. when issues arise). It can be really convenient to have them around when things go badly.
The difference is 250MB vs 450MB.
I would agree that running Artemis in development JDK tools could be needed, but I don't agree that including these tools in production (even if needed sometimes) is good idea. Generally production images should be as slim as possible to reduce attack surface, size for fast deployment, etc. etc. If debugging in production is needed one can always use tools like "kubectl debug" which allows to map another container with tools, side by side.
Maybe it is better to have two Dockerfiles then, one for development and one for production, clearly marked? If you think that would be better, I can adjust PR. Also it's probably wise to forgo Debian image as it is built against deprecated openjdk image which is not updated anymore https://github.com/docker-library/openjdk/issues/505
@ViliusS I think having the option to choose JRE or JDK would be great since one size doesn't fit all in this case.
OK, I have added JRE option as a separate Dockerfile.
I have also removed Debian image which used now deprecated OpenJDK build, and converted CentOS image to also use Eclipse-Temurin. Previous jboss/base-jdk image was not updated for the past 2 years.
Hopefully this will satisfy everyone.