activemq-artemis icon indicating copy to clipboard operation
activemq-artemis copied to clipboard

Published 20 hours ago • verified publisher icon apache

ARTEMIS-3050 Reduce PagedReferenceImpl memory footprint

Open franz1981 opened this issue 3 years ago • 6 comments

https://issues.apache.org/jira/browse/ARTEMIS-3050

franz1981 avatar Jan 05 '21 13:01 franz1981

This one should be safe to be merged

franz1981 avatar Jan 25 '21 07:01 franz1981

lets postpone this PR.. and think about the WeakREference on PagedReference

perhaps this will be ok, as the messages will be sent through the LInkedList on Queue in certain occasions. I guess if we make the WeakReference on PagedReference a strong reference, it willl probably be ok.

clebertsuconic avatar Feb 03 '21 16:02 clebertsuconic

postponing after the next release... as discussed.

clebertsuconic avatar Feb 04 '21 20:02 clebertsuconic

@clebertsuconic / @franz1981 whats occuring with this, wanting to start clearing down old / stagnant PR's a bit of spring cleaning so to say - so we focus on stuff thats actively working on / relevant .

michaelandrepearce avatar Sep 06 '21 10:09 michaelandrepearce

@michaelandrepearce I was waiting the comment of @clebertsuconic

postponing after the next release... as discussed.

So don't know yet what are the replacement/proposal to replace it yet

franz1981 avatar Sep 06 '21 10:09 franz1981

I'm converting this to a draft and removing the DO-NOT-MERGE-YET label. Using the draft functionality is a bit more elegant. That said, it would be great to either get this merged or just close it. What do you think @clebertsuconic, @franz1981?

jbertram avatar Feb 11 '22 19:02 jbertram

@clebertsuconic, what do you think about this PR now that you've eliminated the soft cache? Should we merge it or close it?

jbertram avatar Dec 15 '22 23:12 jbertram