Replace `admin signalShutdown` with a better name
Command was added at:
https://github.com/apache/accumulo/pull/5193/files#diff-0632e2094904d132ddf08b3f00a0b682964e9045130748e7d9a31e93e630f6f1R325
It was suggested we might have a better name
The genesis for this issue was a comment that maybe we shouldn't use camel case names for cli commands. Looking at Admin, seems like using camel case is the standard.
cl.addCommand("serviceStatus", serviceStatusCommandOpts);
cl.addCommand("changeSecret", changeSecretCommand);
cl.addCommand("checkTablets", checkTabletsCommand);
cl.addCommand("deleteZooInstance", deleteZooInstOpts);
cl.addCommand("dumpConfig", dumpConfigCommand);
cl.addCommand("fate", fateOpsCommand);
cl.addCommand("signalShutdown", gracefulShutdownCommand);
cl.addCommand("listInstances", listInstancesOpts);
cl.addCommand("locks", tServerLocksOpts);
cl.addCommand("ping", pingCommand);
cl.addCommand("restoreZoo", restoreZooOpts);
cl.addCommand("randomizeVolumes", randomizeVolumesOpts);
cl.addCommand("stop", stopOpts);
cl.addCommand("stopAll", stopAllOpts);
cl.addCommand("stopManager", stopManagerOpts);
cl.addCommand("stopMaster", stopMasterOpts);
cl.addCommand("verifyTabletAssigns", verifyTabletAssignmentsOpts);
cl.addCommand("volumes", volumesCommand);
hey @dlmarion can u pls give a bit information about the issue?? :)
If we've had a release with the old names, we can keep them as a deprecated alias. Since these names are typed on the command-line, rather than representing code, I think more normal command naming convention for these would be something like "stop-manager" instead of "stopManager", so they can be more easily read and written by humans interacting with the command-line.
For "signalShutdown", maybe "request-shutdown" or "send-shutdown-signal"?
@richochetclementine1315 it looks like you are working on a fix for this. I'll assign you to this ticket for now.
Moved to the 4.0 milestone based on conversation in #5565
I am going to explore merging the admin stop and admin signalShutdown commands. https://github.com/apache/accumulo/pull/5734#discussion_r2214054262
#5745 removed the command and merged it into the existing stop command