accumulo icon indicating copy to clipboard operation
accumulo copied to clipboard
verified publisher icon apache

scan server metrics from #4458 based on #4459

Open EdColeman opened this issue 1 year ago • 2 comments

This PR is based on the changes proposed by @keith-turner in #4458, using the changes in #4459 as the base.

  • includes updated documentation in MetricsProducer
  • includes cache metrics for table metadata cache in sserver (resolves todo)

These changes have not be test yet.

These changes should not be merged until #4459 is complete.

EdColeman avatar Apr 15 '24 12:04 EdColeman

@EdColeman I added commit d8b4c66e22b9efcd252e122031fc4513345e6713 to #4458 that could be merged into this

keith-turner avatar Apr 15 '24 15:04 keith-turner

@keith-turner I believe this is up to date with your additions, if not we can add them before merge, This was rebased with the other metric changes so the change-set is more reasonable to review.

EdColeman avatar Apr 24 '24 21:04 EdColeman

Changes in 5dd3c2d311

  • Renames String METRICS_SCAN_PREFIX from accumulo.tserver.scans. to accumulo.scan. Service type (tserver, sserver) is available in the tags
  • Renames registration to reservation to reflect usage.

EdColeman avatar May 01 '24 13:05 EdColeman

@EdColeman I was experimenting with these changes and I was not seeing the stats I expected from the cache. Finally figured out that stats have to be enabled when building the cache, so pushed a change to do that in 3660ecd.

I was using MetricsIT to experiment with these changes when trying to figure this out, can see those changes here b3fdae9630b9719f7b3fcd7f2e6fae664f2dd1a4 if interested.

keith-turner avatar May 02 '24 23:05 keith-turner