accumulo icon indicating copy to clipboard operation
accumulo copied to clipboard

MeterRegistryFactory lacks mechanism for configuration.

Open keith-turner opened this issue 1 year ago • 2 comments

The MeterRegistryFactory does not have any mechanism for passing configuration. Since its likely metrics will need configuration (like a server to send metrics to) this leads to placing the configuration for the MeterRegistryFactory class and any options needed by the class in different places. For example the MeterRegistryFactory class would be configured in accumulo.properties files and if it needs the hostname of a server this might be set as java system prop in accumulo-env.sh.

This plugin could be modified to follow the pattern of many other SPI plugins for passing configuration to a plugin. Since a new type is being introduced in #4244, that presents a good opportunity to make this change.

keith-turner avatar Feb 14 '24 15:02 keith-turner

Marked this for version 2.1.3 on the assumption that #4244 will be in 2.1.3. If that turns out to not be the case then the version on this could change.

keith-turner avatar Feb 14 '24 15:02 keith-turner

I am currently working this as part of #4244

EdColeman avatar Feb 14 '24 16:02 EdColeman

@EdColeman - was this implemented in #4459 as part of the new MeterRegistryFactory SPI class? If so, can this be closed?

dlmarion avatar May 01 '24 18:05 dlmarion

Completed with #4459

EdColeman avatar May 01 '24 18:05 EdColeman