Add delay to allow for ZooKeeper, Update prop names
The ExternalCompaction tests seem to fail occasionally with the compaction coordinator unable to read information from ZooKeeper to create the metrics used in the test.
- Adds a delay with a back off initializing metrics to allow more time for the test cluster ZooKeeper to start up.
- Modifies the compaction service property names to align with changes in #3915 (reduces deprecated property name logging)
This seems to be a partial fix and there seem to be other issues running the tests reliably.
- test still occasionally hang (seems prevalent running in an IDE with ExternalCompaction_2_IT ) this was the most recent Jenkins failure, so this test was run more so it could be generic to the other tests.
- some of the tests may be passing with a false positive. Sometimes the following is in the logs:
ExternalCompaction_2_IT. testDeleteTableCancelsUserExternalCompaction:
2023-11-26T20:35:52,091 [lock.ServiceLock] WARN : Child found with invalid format: wsn2:9133 (does not start with zlock#)
These issues can be a follow-up if these changes are accepted before those are resolved.
2023-11-26T20:35:52,091 [lock.ServiceLock] WARN : Child found with invalid format: wsn2:9133 (does not start with zlock#)
I have been noticing this too in the elasticity branch. Interesting to see that it's in main also. I'm going to try and track this down.
2023-11-26T20:35:52,091 [lock.ServiceLock] WARN : Child found with invalid format: wsn2:9133 (does not start with zlock#)
I have been noticing this too in the
elasticitybranch. Interesting to see that it's inmainalso. I'm going to try and track this down.
Looks like I introduced this in #3951 . Working on a fix.
Closing in favor of #4210