Configure block cache for Recovery

Open milleruntime opened this issue 3 years ago • 4 comments

Closes #882

Mar 25 '22 18:03 milleruntime

@keith-turner I came up with some ideas for how this can be done in a7c51c6. It is not finished so let me know what you think before I go any further.

Mar 28 '22 16:03 milleruntime

@keith-turner I think I may have found what I need with IteratorAdapter. I am going to rework this change so please stand by.

Mar 30 '22 11:03 milleruntime

Do you think setting this to draft while you look at IteratorAdapter would be appropriate?

Mar 30 '22 11:03 EdColeman

@keith-turner I figured out the problem I was having with the RecoveryLogsIterator by using the IteratorAdapter. @ctubbsii expressed concern whether adding complexity to this code is worth the benefits of using a shared block cache for recovery. I am not sure it is so this may be worth holding off for the next version to see how the new changes to the recovery react in a production environment.

Apr 05 '22 16:04 milleruntime