clj-rethinkdb icon indicating copy to clipboard operation
clj-rethinkdb copied to clipboard

Add missing tests

Open danielcompton opened this issue 8 years ago • 9 comments

There are a bunch of query terms that don't have tests. If you're looking to help contribute to the driver, adding tests for some of these would be a great help.

  • [x] index-status
  • [x] index-wait
  • [x] inner-join
  • [x] outer-join
  • [ ] eq-join
  • [x] zip
  • [x] with-fields
  • [x] concat-map
  • [x] skip
  • [x] limit
  • [x] slice
  • [x] nth
  • [x] indexes-of
  • [x] is-empty
  • [x] union
  • [x] sample
  • [x] group
  • [x] ungroup
  • [x] reduce
  • [x] count
  • [x] contains
  • [x] pluck
  • [x] append
  • [x] prepend
  • [x] difference
  • [x] set-insert
  • [x] set-union
  • [x] set-intersection
  • [x] set-difference
  • [x] has-fields
  • [x] insert-at
  • [x] splice-at
  • [x] delete-at
  • [x] change-at
  • [x] keys
  • [x] values
  • [ ] literal
  • [x] object
  • [x] sub
  • [x] mul
  • [x] div
  • [x] mod
  • [x] not
  • [x] now
  • [ ] for-each
  • [x] http
  • [x] desc
  • [x] to-geojson
  • [ ] get-intersection
  • [ ] get-nearest
  • [x] includes
  • [x] intersects
  • [x] polygon
  • [x] polygon-sub
  • [x] rebalance

danielcompton avatar Nov 20 '15 03:11 danielcompton

@anthonygalea Thanks for your awesome work on this! 👍

danielytics avatar May 04 '16 14:05 danielytics

woooo!

bhurlow avatar May 04 '16 14:05 bhurlow

@anthonygalea so much ❤️ for this

lukaszkorecki avatar May 04 '16 15:05 lukaszkorecki

my pleasure

anthonygalea avatar May 04 '16 18:05 anthonygalea

Hi all, I'm interested in helping. Is the above checklist still up to date?

ds2643 avatar Sep 26 '16 23:09 ds2643

It should be close, though there might be some for joins.

danielcompton avatar Sep 27 '16 07:09 danielcompton

I'm going to try and work on this a little, anything I need to know about?

DonyorM avatar Dec 27 '16 10:12 DonyorM

@DonyorM should be pretty close to up to date, leave a comment here if there's anything missed though.

danielcompton avatar Jan 02 '17 02:01 danielcompton

@danielcompton Ok thank you. I submitted a pull request adding some of the joins tests. I believe someone also added a test for the eq-joins tests.

DonyorM avatar Jan 02 '17 02:01 DonyorM